Skip to content

move storageobs to protocol #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frostbyte73 merged 1 commit into from
Feb 2, 2026
Merged

move storageobs to protocol #1398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions observability/reporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"github.com/livekit/protocol/observability/gatewayobs"
"github.com/livekit/protocol/observability/ingressobs"
"github.com/livekit/protocol/observability/roomobs"
"github.com/livekit/protocol/observability/storageobs"
"github.com/livekit/protocol/observability/telephonycallobs"
"github.com/livekit/protocol/observability/telephonyobs"
)
Expand All @@ -22,7 +23,7 @@ type Reporter interface {
Ingress() ingressobs.Reporter
GatewayMetrics() any // any is a placeholder for the gateway metrics type
TelephonyCall() telephonycallobs.Reporter
Storage() any
Storage() storageobs.Reporter
Close()
}

Expand Down Expand Up @@ -68,7 +69,7 @@ func (reporter) TelephonyCall() telephonycallobs.Reporter {
return telephonycallobs.NewNoopReporter()
}

func (reporter) Storage() any { return nil }
func (reporter) Storage() storageobs.Reporter { return storageobs.NewNoopReporter() }

func (reporter) Close() {
}
46 changes: 46 additions & 0 deletions observability/storageobs/gen_reporter.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

64 changes: 64 additions & 0 deletions observability/storageobs/gen_reporter_noop.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions observability/storageobs/gen_source.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading