Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add play-dialtone option to sip transfer #452

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

biglittlebigben
Copy link
Contributor

No description provided.

@biglittlebigben biglittlebigben changed the title Add play-ringtone option to sip transfer Add play-dialtone option to sip transfer Oct 22, 2024
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@biglittlebigben biglittlebigben merged commit a53ca45 into main Oct 23, 2024
3 checks passed
@biglittlebigben biglittlebigben deleted the benjamin/deprecate_create_trunk branch October 23, 2024 17:01
@rektdeckard
Copy link
Contributor

Missed opportunity to --play-elevator-music

@biglittlebigben
Copy link
Contributor Author

Missed opportunity to --play-elevator-music

More seriously, this is why the dialtone behavior is not the default. We expect most customers to want to play something specific through the room during the refer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants