Add room connect disconnect hack #1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67e41a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
lukasIO
reviewed
Aug 11, 2025
| * | ||
| * @public | ||
| */ | ||
| export function useSequentialRoomConnectDisconnect( |
There was a problem hiding this comment.
it's a very descriptive name.
Definitely can see why you chose the name, but if you can think of something a bit more concise I wouldn't mind 😅
There was a problem hiding this comment.
It's a really hard one to name... that one was the best I could come up with. I'll keep pondering it but definitely open to suggestions!
1egoman
commented
Aug 11, 2025
1egoman
force-pushed
the
add-room-connect-disconnect-hack
branch
6 times, most recently
from
de6e0dc to
1b81b55
Compare
1egoman
force-pushed
the
add-room-connect-disconnect-hack
branch
from
1b81b55 to
67e41a3
Compare
lukasIO
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @lukasIO's and my discussion, adds a hook that can be used to work around
useEffects not waiting for aroom.disconnect()to finish in the cleanup function before running aroom.connect().I tested it out in
agent-starter-embedand it seemed to do what was expected.