fix(core): prevent audio output switching on safari based browsers #1190
Conversation
🦋 Changeset detectedLatest commit: c6bbee3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| const browser = getBrowser(); | ||
| if (kind === 'audiooutput' && (browser?.name === 'Safari' || browser?.os === 'iOS')) { | ||
| log.warn(`Switching audio output device is not supported on Safari and iOS.`); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Is this the kind of thing it's worth throwing an error for because it should never happen?
There was a problem hiding this comment.
Hm, if we were to throw an error here we would have to integrate some way to automatically detect feature support also in the MediaDeviceSelect component.
I'm still not sure how to tackle this particular situation in the long term. We probably eventually want to support iOS, just that right now it's tricky to get the correct user-initiated permission for it to happen consistently.
I'll leave this as is for now
2 participants
No description provided.