Skip to content

Update audio session logic #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 28, 2025
Merged

Update audio session logic #696

merged 8 commits into from
May 28, 2025

Conversation

hiroshihorie
Copy link
Member

Fixes isSpeakerOutputPreferred = false not working.

@hiroshihorie hiroshihorie marked this pull request as ready for review May 14, 2025 16:36
@pblazej
Copy link
Contributor

pblazej commented May 19, 2025

Tested with BT speaker, for me this flag still does nothing (until I just switch the device via AirPlay menu).

@hiroshihorie
Copy link
Member Author

hiroshihorie commented May 19, 2025

This isn't for switching Device / Bluetooth it's for switching Built-in Speaker / Receiver. This was the behavior for this flag in previous versions but it broke at some point...

Copy link
Contributor

@pblazej pblazej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, routes to the 🔈

@hiroshihorie
Copy link
Member Author

Thanks for testing 🙏

@hiroshihorie hiroshihorie merged commit 930c962 into main May 28, 2025
19 of 20 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/fix-preferred-output branch May 28, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants