Skip to content

Fix external webcam visibility on macOS #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pblazej
Copy link
Contributor

@pblazej pblazej commented May 6, 2025

Handles .unspecified position

@pblazej pblazej requested a review from hiroshihorie May 6, 2025 09:00
@pblazej pblazej changed the title Don't filter cam position on macOS Fix external webcam visibility on macOS May 6, 2025
@hiroshihorie
Copy link
Member

I've added facingPosition as an extension on AVCaptureDevice so please take a look there (if you haven't already) 🙂

@pblazej
Copy link
Contributor Author

pblazej commented May 6, 2025

I've added facingPosition as an extension on AVCaptureDevice so please take a look there (if you haven't already) 🙂

I think it's too restrictive tho if deviceType == .builtInWideAngleCamera - it does not handle external cams. We can remove this part instead.

@pblazej
Copy link
Contributor Author

pblazej commented May 6, 2025

I've added facingPosition as an extension on AVCaptureDevice so please take a look there (if you haven't already) 🙂

I think it's too restrictive tho if deviceType == .builtInWideAngleCamera - it does not handle external cams. We can remove this part instead.

Hm, but it comes at the cost of filtering out built-in camera. Are we sure we don't wanna handle all 3 positions instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants