Skip to content

Add Sendable for internal callbacks #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

Add Sendable for internal callbacks #686

merged 3 commits into from
Apr 30, 2025

Conversation

pblazej
Copy link
Contributor

@pblazej pblazej commented Apr 30, 2025

So that consumers like:

AudioManager.shared.onDeviceUpdate = { [weak self] _ in
            guard let self else { return }
            // force UI update for outputDevice / inputDevice
            Task { @MainActor [weak self] in

have proper isolation.

@pblazej pblazej requested a review from hiroshihorie April 30, 2025 08:30
@pblazej pblazej changed the title Adds Sendable for internal callbacks Add Sendable for internal callbacks Apr 30, 2025
Copy link
Member

@hiroshihorie hiroshihorie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pblazej pblazej merged commit 4b582a1 into main Apr 30, 2025
19 of 20 checks passed
@pblazej pblazej deleted the blaze/sendable-callbacks branch April 30, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants