Mark state-derived props nonisolated #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to refer to the manpage for more information. |
hiroshihorie
approved these changes
Apr 18, 2025
hiroshihorie
pushed a commit
that referenced
this pull request
Apr 22, 2025
Resolves #678 Follow-up of #679 I managed to reproduce the issue, steps: - open example app on iPhone (non-sample buffer mode) - join from e.g. macOS - publish/unpublish camera track on mac The diagnosis was correct - logs are coming via unsafe `UIView`/`NSObject` territory, so main actor isolated props are listed from bg threads. The last one was `isHidden`. I also overrode the `description` string, just in case... for every descendant of `NativeView` (that may inherit the description). <img width="1483" alt="Screenshot 2025-04-22 at 10 40 14 AM" src="https://github.com/user-attachments/assets/441d9bd8-6ecd-4b45-93b0-34517c6dab2b" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #678
Properties behind
_statecan be markednonisolatedto avoid crashes when accessed from bg threads (in a@MainActor-isolated video view).