Unified CI workflow #618
Merged
Unified CI workflow #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create single workflow for building, testing, linting, and doc generation - Update publish docs workflow to use pre-built docs - Create empty documentation catalog
|
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to refer to the manpage for more information. |
Closed
hiroshihorie
approved these changes
Mar 6, 2025
bcherry
reviewed
Mar 6, 2025
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| TESTS: "FunctionTests SDKTests RoomTests PublishDataTests PublishBufferCapturerTests VideoViewTests TrackTests" |
There was a problem hiding this comment.
is this really necessary? seems like an easy trap that we'll add new tests but forget to add them here and thus CI won't actually run them
There was a problem hiding this comment.
This part was copied from the existing test workflow.
There was a problem hiding this comment.
Yes Ben is right, but some tests don't run on CI/Simulator needs device etc. We can organize this in another PR.
When run for PRs, ref name can contain "/" which is not file path safe.
bcherry
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a unified CI workflow that performs building, testing, linting, and documentation generation. This brings several advantages:
symbol-graphset to true will trigger a release build with symbol graphs emitted—these will then be used to build docs.