Skip to content

Fail to publish instead of crash when mic not available #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 7, 2025

Conversation

hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Mar 5, 2025

Copy link

ilo-nanpa bot commented Mar 5, 2025

it seems like you haven't added any nanpa changeset files to this PR.

if this pull request includes changes to code, make sure to add a changeset, by writing a file to .nanpa/<unique-name>.kdl:

minor type="added" "Introduce frobnication algorithm"

refer to the manpage for more information.

@hiroshihorie hiroshihorie changed the title AudioEngine avoid format crash Fail to publish instead of crashing when mic not available Mar 5, 2025
@hiroshihorie hiroshihorie changed the title Fail to publish instead of crashing when mic not available Fail to publish instead of crash when mic not available Mar 5, 2025
@hiroshihorie hiroshihorie marked this pull request as ready for review March 5, 2025 15:46
@hiroshihorie hiroshihorie requested a review from ladvoc March 6, 2025 18:26
Copy link
Contributor

@ladvoc ladvoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@hiroshihorie hiroshihorie merged commit 0dd5a09 into main Mar 7, 2025
14 of 16 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/audioengine-avoid-format-crash branch March 7, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants