Skip to content

Fix test execution #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Fix test execution #600

merged 1 commit into from
Feb 22, 2025

Conversation

ladvoc
Copy link
Contributor

@ladvoc ladvoc commented Feb 21, 2025

Test execution currently fails due to logging being bootstrapped both in AudioEngineTests and VideoViewTests. This PR defines LKTestCase, a subclass of XCTestCase, which performs global initialization once per execution. All existing test cases now use this as their superclass.

Subclasses `XCTestCase` to perform global initalization once per execution.
Copy link

ilo-nanpa bot commented Feb 21, 2025

it seems like you haven't added any nanpa changeset files to this PR.

if this pull request includes changes to code, make sure to add a changeset, by writing a file to .nanpa/<unique-name>.kdl:

minor type="added" "Introduce frobnication algorithm"

refer to the manpage for more information.

@hiroshihorie hiroshihorie self-requested a review February 22, 2025 00:31
@hiroshihorie hiroshihorie merged commit 0440e22 into livekit:main Feb 22, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants