Fix callback loop with metadata updates #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When canUpdateOwnMetadata grant is given to the participant, and metadata is updated remotely, it would throw the client into an invite loop in updating metadata with previous and current value. This was really tricky to root cause. The way it happened was: * RoomService.UpdateParticipant is called * Participant.updateInfo called with new metadata * LocalParticipant.setName called with the same name * setName triggers a `sendUpdateLocalMetadata` with previous metadata * LocalParticipant.setMetadata called with new metadata * setMetadata triggers a `sendUpdateLocalMetadata` with new metadata * Participant.updateInfo called with old metadata....
🦋 Changeset detectedLatest commit: cfb8a55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
lukasIO
reviewed
Sep 13, 2023
src/room/participant/Participant.ts
Outdated
| /** | ||
| * Updates metadata from server | ||
| **/ | ||
| protected _setMetadata(md: string) { |
There was a problem hiding this comment.
if LocalParticipant isn't supposed to implement this, should we make the method private?
(same question for _setName)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When canUpdateOwnMetadata grant is given to the participant, and metadata is updated remotely, it would throw the client into an infinite loop in updating metadata with previous and current value.
This was really tricky to root cause. The way it happened was:
sendUpdateLocalMetadatawith previous metadatasendUpdateLocalMetadatawith new metadata