Skip to content

Conversation

davidliu
Copy link
Contributor

@davidliu davidliu commented Aug 9, 2023

No description provided.

@davidliu davidliu requested a review from lukasIO August 9, 2023 14:16
@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

🦋 Changeset detected

Latest commit: 49f65de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 75.67 KB (+0.03% 🔺)
dist/livekit-client.umd.js 81.03 KB (+0.03% 🔺)

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! would the getVolume method need a similar condition if elementVolume hasn't been set previously?

@davidliu
Copy link
Contributor Author

davidliu commented Aug 9, 2023

Ah yeah, good point. No equivalent getVolume method, but I think it defaults to 1 anyways.

@davidliu davidliu merged commit 53068ce into main Aug 14, 2023
@davidliu davidliu deleted the dl/rn_audio_volume branch August 14, 2023 14:23
@github-actions github-actions bot mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants