prepareConnection to better support Cloud routing and region-pinning #783
Conversation
🦋 Changeset detectedLatest commit: 49a862b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
src/room/Room.ts
Outdated
| // trigger the first fetch without waiting for a response | ||
| // if initial connection fails, this will speed up picking regional url | ||
| // on subsequent runs | ||
| this.regionUrlProvider.fetchRegionSettings().catch((e) => { |
There was a problem hiding this comment.
I think this line can go after the else clause so that it runs even if regionUrlProvider has been set by a previous prepareConnection call already?
also on disconnect we currently don't clear the regionUrlProvider. so with the sequence connect -> disconnect -> connect we would skip fetching region settings the second time around currently.
would probably make sense to at least resetAttempts of the url provider on disconnect/engine closing.
There was a problem hiding this comment.
yeah makes sense. it should clear out all the previous urls + providers as the primary url may have changed. I'll make that change
When using Cloud, establish connection to fetch region URL so we have better control of routing decisions.
For projects with region-pinning enabled,
/settings/regionswould only return regions that are allowed. if prepareConnections is not used, Cloud would reject the initial connection if DNS-based routing ends up connecting to a disallowed region.