Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dimensions when the remote track is detached #766

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Update dimensions when the remote track is detached #766

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
67736e7
Update dimensions when the remote track is detached
burzomir Jul 5, 2023
c1212c7
Move updateDimensions to stopObservingElementInfo
burzomir Jul 5, 2023
bd86b5b
Fix formatting
burzomir Jul 5, 2023
e4b33f6
Use debouncedHandleResize instead of updateDimensions
burzomir Jul 5, 2023
992fe29
Remove redundant cleanup of elementInfos
burzomir Jul 5, 2023
90ce2fa
Create funny-dingos-pay.md
lukasIO Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/room/track/RemoteVideoTrack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ export default class RemoteVideoTrack extends RemoteTrack {
}
this.elementInfos = this.elementInfos.filter((info) => info !== elementInfo);
this.updateVisibility();
this.updateDimensions();
}

detach(): HTMLMediaElement[];
Expand Down Expand Up @@ -195,7 +196,7 @@ export default class RemoteVideoTrack extends RemoteTrack {
private stopObservingElement(element: HTMLMediaElement) {
const stopElementInfos = this.elementInfos.filter((info) => info.element === element);
for (const info of stopElementInfos) {
info.stopObserving();
this.stopObservingElementInfo(info);
}
this.elementInfos = this.elementInfos.filter((info) => info.element !== element);
}
Expand Down