Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose facingMode functions #753

Merged
merged 2 commits into from
Jun 23, 2023
Merged

expose facingMode functions #753

merged 2 commits into from
Jun 23, 2023

Conversation

Ocupe
Copy link
Contributor

@Ocupe Ocupe commented Jun 23, 2023

I forgot to expose the new facing mode functions. 🤦
This PR exposes the functions and also moves them to a more descriptive separate module.

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2023

🦋 Changeset detected

Latest commit: 773c21f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Ocupe Ocupe requested review from lukasIO and theomonnom June 23, 2023 13:53
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 82.99 KB (+0.03% 🔺)
dist/livekit-client.umd.js 87.1 KB (+0.33% 🔺)

Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't see that!
lgtm :)

@Ocupe Ocupe merged commit 5f579af into main Jun 23, 2023
@Ocupe Ocupe deleted the expose-facingMode-functions branch June 23, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants