Support screen pixel density for react native #651
Conversation
🦋 Changeset detectedLatest commit: af19cb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -20,3 +20,8 @@ export type DataPublishOptions = { | |||
| /** the topic under which the message gets published */ | |||
| topic?: string; | |||
| }; | |||
|
|
|||
| export type LiveKitReactNativeInfo = { | |||
| platform: 'ios' | 'android' | 'windows' | 'macos' | 'web' | 'native'; | |||
There was a problem hiding this comment.
out of curiosity: does RN support all these platforms and what does native stand for?
There was a problem hiding this comment.
Apparently there is support for all of these platforms, though we only support ios/android.
The typing here is from RN's platform types, though doesn't seem like anything actually uses native; it just happens to be added to the type and left there.
src/room/utils.ts
Outdated
| } | ||
|
|
||
| return undefined; | ||
| } | ||
|
|
||
| export function getDevicePixelRatio(): number { | ||
| if (!isReactNative()) { |
There was a problem hiding this comment.
we're not calling getDevicePixelRatio in "dangerous" paths right now, but adding a isWeb() check additionally wouldn't hurt either.
No description provided.