Add fps to subscribe setting #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2b1ea3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasIO
reviewed
Oct 24, 2022
lukasIO
reviewed
Oct 24, 2022
lukasIO
reviewed
Oct 25, 2022
| @@ -143,6 +145,23 @@ export default class RemoteTrackPublication extends TrackPublication { | |||
| this.emitTrackUpdate(); | |||
| } | |||
|
|
|||
| setVideoFPS(fps: number) { | |||
There was a problem hiding this comment.
nit: as we do not know for certain that this will actually result in the desired fps, maybe naming it setPreferredVideoFPS would be communicating more clearly what it is doing?
There was a problem hiding this comment.
Yeah, it is more clear, we have discussed this during the subscribed fps design, just want to keep same as setVideoDimensions, it is a preference too.
lukasIO
approved these changes
Oct 25, 2022
Merged
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 5, 2022
* Add fps to subscribe setting * solve comments
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 5, 2022
* Add fps to subscribe setting * solve comments
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 9, 2022
* Add fps to subscribe setting * solve comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.