Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stuck reconnect #475

Merged
merged 19 commits into from
Oct 20, 2022
Merged

Fix stuck reconnect #475

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b49c959
retry initial signal connection
lukasIO Sep 30, 2022
7a32102
changeset
lukasIO Sep 30, 2022
bde01dd
move retry logic into rtcEngine
lukasIO Oct 10, 2022
3854a93
make maxJoinAttempts configurable
lukasIO Oct 10, 2022
8fe01bf
merge main into lukas/retry-signal-connection
lukasIO Oct 10, 2022
7beeeb9
update changeset
lukasIO Oct 10, 2022
2ff6b45
typo
lukasIO Oct 10, 2022
45f2d26
move maxRetries into connectOpts
lukasIO Oct 18, 2022
480a29f
merge main into retry-signal-connection
lukasIO Oct 18, 2022
bd58b30
wip
lukasIO Oct 18, 2022
ab83683
more logic in engine
lukasIO Oct 18, 2022
b3d67da
remove comment
lukasIO Oct 18, 2022
0c393b4
fix connect logic
lukasIO Oct 18, 2022
10efda5
Merge branch 'main' into lukas/fix-stuck-reconnect
lukasIO Oct 19, 2022
cc76f39
don't reject reconnect promise
lukasIO Oct 19, 2022
ca04629
replace reconnectFuture with event driven logic
lukasIO Oct 19, 2022
8ee43c8
changeset
lukasIO Oct 19, 2022
8a2dc46
Update src/room/RTCEngine.ts
lukasIO Oct 20, 2022
6837e81
change naming
lukasIO Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/room/RTCEngine.ts 
Co-authored-by: David Zhao <dz@livekit.io>
  • Loading branch information
@lukasIO @davidzhao
lukasIO and davidzhao authored Oct 20, 2022
commit 8a2dc468b8b7828baf200852ad42d85cc54dadf9
2 changes: 1 addition & 1 deletion src/room/RTCEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit
close() {
this._isClosed = true;
this.removeAllListeners();
this.unRegisterOnLineListener();
this.deregisterOnLineListener();
this.clearPendingReconnect();
if (this.publisher && this.publisher.pc.signalingState !== 'closed') {
this.publisher.pc.getSenders().forEach((sender) => {
Expand Down