CheckStatus is an enum and shouldn't be exported as type#1855
Merged
1egoman merged 2 commits intolivekit:mainfrom Apr 3, 2026
Merged
CheckStatus is an enum and shouldn't be exported as type#18551egoman merged 2 commits intolivekit:mainfrom
1egoman merged 2 commits intolivekit:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 613d3f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1egoman
approved these changes
Apr 3, 2026
Contributor
1egoman
left a comment
1egoman
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the contribution!
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckStatusis implemented as an enum inChecker.tsbut re-exported as a type fromConnectionCheck.ts. This causes issues for users trying to use CheckStatus values directly, for instance when building custom connection tester logic.With the current declaration, importing
CheckStatusfromlivekit-clientwithverbatimModuleSyntaxenabled (default in modern SvelteKit/Vite setups) raises a TS error, and using import type makes the enum values undefined at runtime.Minimal reproduction: TypeScript Playground
Fix:
CheckInfois interface-only so it stays type, butCheckStatusis a runtime enum and shouldn't be marked as type-only.