Enable E2EE key-size configuration via ExternalE2EEKeyProvider options#1841
Conversation
🦋 Changeset detectedLatest commit: dee4386 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
MariusBernhardt
force-pushed
the
enable-config-for-256-bit-key-for-e2ee
branch
2 times, most recently
from
c6c6e1c to
5e6113c
Compare
1egoman
left a comment
1egoman
left a comment
There was a problem hiding this comment.
Hi, thanks for the contribution!
Reading through the change it generally makes sense to me, but before merging it let me check with the wider team to see if there are plans to support > 128 bit keys on other clients.
| ratchetWindowSize: number; | ||
| failureTolerance: number; | ||
| keyringSize: number; | ||
| keySize: 128 | 256; |
There was a problem hiding this comment.
Introducing this might add confusion as-is if the web sdk is the only sdk which supports longer keys (and from a quick search I believe this is the case).
Could you add a docstring above this new keySize parameter which mentions its default value of 128 and that 128 is the only value supported by other non web sdks?
There was a problem hiding this comment.
Cool, no problem. I added the comment with the hint.
MariusBernhardt
force-pushed
the
enable-config-for-256-bit-key-for-e2ee
branch
from
5e6113c to
281d47e
Compare
1egoman
left a comment
1egoman
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
3 participants
Hello,
I have a client with a hard requirement to 256-bit key-size for the E2EE of media streams.
With this PR I would like to add the option of enabling 256-bit key length instead of the default 128-bit length via the constructor options of the ExternalE2EEKeyProvider.
So 256-bit key length can be configured like so:
const keyProvider = new ExternalE2EEKeyProvider({keySize: 256});thanks