Skip to content

Fix error when unwrapConstraint receives an empty deviceId when creating local tracks #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mpnri
Copy link
Contributor

@mpnri mpnri commented Jul 8, 2025

Hi.
When createLocalTracks is called with an empty string deviceId ({deviceId: ""}), the unwrapConstraint function throws an error because it incorrectly evaluates empty strings as falsy values. This causes the function to throw "could not unwrap constraint" error when creating local tracks (audio or video)

and also it prevents the code properly clean up and stop created media tracks, resulting in browsers continuing to show camera/microphone in-use indicators even after the meet ends or fails.

create.ts

const newDeviceId = mediaStreamTrack.getSettings().deviceId;
if (
  trackConstraints?.deviceId &&
  //* this line throws when deviceId is an empty string in constraints
  //* like `{ ideal: "" }` or `{ exact: "" }`
  unwrapConstraint(trackConstraints.deviceId) !== newDeviceId
) {
  trackConstraints.deviceId = newDeviceId;
} else if (!trackConstraints) {
  trackConstraints = { deviceId: newDeviceId };
}

Copy link

changeset-bot bot commented Jul 8, 2025

⚠️ No Changeset found

Latest commit: 9d478e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant