Fix error when unwrapConstraint
receives an empty deviceId when creating local tracks
#1594
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
When
createLocalTracks
is called with an empty string deviceId ({deviceId: ""}
), theunwrapConstraint
function throws an error because it incorrectly evaluates empty strings as falsy values. This causes the function to throw"could not unwrap constraint"
error when creating local tracks (audio or video)and also it prevents the code properly clean up and stop created media tracks, resulting in browsers continuing to show camera/microphone in-use indicators even after the meet ends or fails.
create.ts