Default to exact matching and retry on unspecified ideal narrowing #1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ac4607b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…t-sdk-js into lukas/handle-preview-exact
Merged
svajunas-budrys
pushed a commit
to svajunas-budrys/client-sdk-js
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
createLocalTracksthis PR changes our stream acquisition handling to default toexactmatching if neitheridealnorexacthave been explicitly specified by the user{ deviceId: "my-device-id" }: Try with exact match if that throws -> try again with "ideal"{ deviceId: { exact: "my-device-id" } }: Same behaviour as before, throws overconstrainederror if it cannot be fulfilled{ deviceId: { ideal: "my-device-id" }}: Browser's ideal behaviour is respected