Skip to content

use a different error code for publish data #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2025
Merged

use a different error code for publish data #1374

merged 2 commits into from
Jan 21, 2025

Conversation

davidzhao
Copy link
Member

previously two diff errors were using the same code 13

@davidzhao
use a different error code for publish data
122e824 
previously two diff errors were using the same code 13
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: 122e824

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 86.97 KB (0%)
dist/livekit-client.umd.js 93.05 KB (0%)

@davidzhao davidzhao merged commit 8871f4e into main Jan 21, 2025
3 checks passed
@davidzhao davidzhao deleted the diff-error-code branch January 21, 2025 21:36
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Merged
@github-actions github-actions bot mentioned this pull request Feb 1, 2025
Open
svajunas-budrys pushed a commit to svajunas-budrys/client-sdk-js that referenced this pull request Jun 17, 2025
@davidzhao @svajunas-budrys
use a different error code for publish data (livekit#1374)
225b6cd 
* use a different error code for publish data

previously two diff errors were using the same code 13

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisackermann chrisackermann chrisackermann approved these changes

@bcherry bcherry Awaiting requested review from bcherry

@lukasIO lukasIO Awaiting requested review from lukasIO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidzhao @chrisackermann