Skip to content

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Sep 26, 2024

No description provided.

Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 5419783

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 26, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 83.25 KB (+0.01% 🔺)
dist/livekit-client.umd.js 89.14 KB (+0.01% 🔺)

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch... I guess this will change the behavior of clients expecting deltas to be the other way?

@lukasIO
Copy link
Contributor Author

lukasIO commented Sep 26, 2024

true, arguably there's a argument to be made that the diff should have the old values, but I'm not sure.

Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the docstring to explain exactly what is included in the emitted event?

@lukasIO lukasIO merged commit 0e9093e into main Sep 27, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/fix-attr-diff branch September 27, 2024 15:25
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
svajunas-budrys pushed a commit to svajunas-budrys/client-sdk-js that referenced this pull request Jun 17, 2025
* Fix changed attribute computation

* Create fast-mice-hunt.md

* args in docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants