Only set volume on attach if elementVolume has been previously set (#371

) * only set volume on attach if elementVolume has been previously set * changeset
livekit · Aug 3, 2022 · e1a004e · e1a004e
1 parent e195221
commit e1a004e
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/.changeset/stale-drinks-love.md b/.changeset/stale-drinks-love.md
@@ -0,0 +1,5 @@
+---
+'livekit-client': patch
+---
+
+only set volume on attach if elementVolume has been previously set
diff --git a/src/room/track/RemoteAudioTrack.ts b/src/room/track/RemoteAudioTrack.ts
@@ -5,11 +5,10 @@ import { Track } from './Track';
 export default class RemoteAudioTrack extends RemoteTrack {
   private prevStats?: AudioReceiverStats;
 
-  private elementVolume: number;
+  private elementVolume: number | undefined;
 
   constructor(mediaTrack: MediaStreamTrack, sid: string, receiver?: RTCRtpReceiver) {
     super(mediaTrack, sid, Track.Kind.Audio, receiver);
-    this.elementVolume = 1;
   }
 
   /**
@@ -23,10 +22,19 @@ export default class RemoteAudioTrack extends RemoteTrack {
   }
 
   /**
-   * gets the volume for all attached audio elements
+   * gets the volume of attached audio elements (loudest)
    */
   getVolume(): number {
-    return this.elementVolume;
+    if (this.elementVolume) {
+      return this.elementVolume;
+    }
+    let highestVolume = 0;
+    this.attachedElements.forEach((element) => {
+      if (element.volume > highestVolume) {
+        highestVolume = element.volume;
+      }
+    });
+    return highestVolume;
   }
 
   attach(): HTMLMediaElement;
@@ -37,7 +45,9 @@ export default class RemoteAudioTrack extends RemoteTrack {
     } else {
       super.attach(element);
     }
-    element.volume = this.elementVolume;
+    if (this.elementVolume) {
+      element.volume = this.elementVolume;
+    }
     return element;
   }