Sync state settings should use desired instead of subscribed (#440)

* Sync state settings should use desired instead of subscribed * better variable name, handle undefined connOptions. * changeset
livekit · Sep 17, 2022 · b74eae6 · b74eae6
1 parent b56c3c4
commit b74eae6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/cold-moles-accept.md b/.changeset/cold-moles-accept.md
@@ -0,0 +1,5 @@
+---
+'livekit-client': patch
+---
+
+Improve handling of connection resume failures
diff --git a/src/room/Room.ts b/src/room/Room.ts
@@ -1061,11 +1061,11 @@ class Room extends (EventEmitter as new () => TypedEmitter<RoomEventCallbacks>)
           subscribe pc and unsub special tracks from it.
        2. autosubscribe off, we send subscribed tracks.
     */
-    const sendUnsub = this.connOptions?.autoSubscribe || false;
+    const autoSubscribe = this.connOptions?.autoSubscribe ?? true;
     const trackSids = new Array<string>();
     this.participants.forEach((participant) => {
       participant.tracks.forEach((track) => {
-        if (track.isSubscribed !== sendUnsub) {
+        if (track.isDesired !== autoSubscribe) {
           trackSids.push(track.trackSid);
         }
       });
@@ -1084,7 +1084,7 @@ class Room extends (EventEmitter as new () => TypedEmitter<RoomEventCallbacks>)
         : undefined,
       subscription: {
         trackSids,
-        subscribe: !sendUnsub,
+        subscribe: !autoSubscribe,
         participantTracks: [],
       },
       publishTracks: this.localParticipant.publishedTracksInfo(),