Clean up simulcast codecs in unpublish (#332)

* reset multicodec senders in unpublish

* dont stop tracks when resetting senders

* remove simulcast codec tracks when unpublishing

* set sender to undefined after removing track

* make sure negotiation happens after removing tracks

* changeset

.changeset/purple-carrots-juggle.md

@@ -0,0 +1,5 @@
+---
+'livekit-client': patch
+---
+
+Clean up simulcast codecs in unpublishTrack

src/room/participant/LocalParticipant.ts

@@ -723,9 +723,19 @@ export default class LocalParticipant extends Participant {
     ) {
       try {
         this.engine.publisher.pc.removeTrack(track.sender);
-        this.engine.negotiate();
+        if (track instanceof LocalVideoTrack) {
+          for (const [, trackInfo] of track.simulcastCodecs) {
+            if (trackInfo.sender) {
+              this.engine.publisher.pc.removeTrack(trackInfo.sender);
+              trackInfo.sender = undefined;
+            }
+          }
+          track.simulcastCodecs.clear();
+        }
       } catch (e) {
         log.warn('failed to remove track', { error: e, method: 'unpublishTrack' });
+      } finally {
+        this.engine.negotiate();
       }
     }
 

src/room/track/LocalVideoTrack.ts

@@ -27,17 +27,15 @@ export class SimulcastTrackInfo {
 const refreshSubscribedCodecAfterNewCodec = 5000;
 
 export default class LocalVideoTrack extends LocalTrack {
-  /* internal */
+  /* @internal */
   signalClient?: SignalClient;
 
   private prevStats?: Map<string, VideoSenderStats>;
 
   private encodings?: RTCRtpEncodingParameters[];
 
-  private simulcastCodecs: Map<VideoCodec, SimulcastTrackInfo> = new Map<
-    VideoCodec,
-    SimulcastTrackInfo
-  >();
+  /* @internal */
+  simulcastCodecs: Map<VideoCodec, SimulcastTrackInfo> = new Map<VideoCodec, SimulcastTrackInfo>();
 
   private subscribedCodecs?: SubscribedCodec[];
 
@@ -78,9 +76,7 @@ export default class LocalVideoTrack extends LocalTrack {
     this._mediaStreamTrack.getConstraints();
     this.simulcastCodecs.forEach((trackInfo) => {
       trackInfo.mediaStreamTrack.stop();
-      trackInfo.sender = undefined;
     });
-    this.simulcastCodecs.clear();
     super.stop();
   }