Skip to content

Fix stream progress #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiroshihorie merged 6 commits into from
Sep 27, 2025
Merged

Fix stream progress #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b361085
Implementation
hiroshihorie Sep 22, 2025
3053e14
Enum for TextStreamOperationType
hiroshihorie Sep 22, 2025
a4c0e45
Fix stream progress
hiroshihorie Sep 22, 2025
d3e165e
Merge main into hiroshi/fix-stream-progress
hiroshihorie Sep 26, 2025
6e3bcd2
Merge branch 'main' into hiroshi/fix-stream-progress
hiroshihorie Sep 26, 2025
05c712c
Test
hiroshihorie Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/src/participant/local.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,8 +1171,7 @@ extension DataStreamParticipantMethods on LocalParticipant {
handleProgress(num progress, int idx) {
progresses[idx] = progress;
final totalProgress = progresses.reduce((acc, val) => acc + val);
options?.onProgress
?.call(totalProgress.toDouble() / (fileIds?.length ?? 1));
options?.onProgress?.call(totalProgress.toDouble() / len);
}

final writer = await streamText(StreamTextOptions(
Expand Down
18 changes: 12 additions & 6 deletions test/core/data_stream_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,10 @@ void main() {
final info = await room.localParticipant?.sendText(longText,
options: SendTextOptions(
topic: 'chat-long-text',
onProgress: (p0) {
print('progress: $p0');
onProgress: (progress) {
print('progress: $progress');
expect(progress, greaterThanOrEqualTo(0.0));
expect(progress, lessThanOrEqualTo(1.0));
},
));
expect(info, isNotNull);
Expand Down Expand Up @@ -149,8 +151,10 @@ void main() {
options: SendTextOptions(
topic: 'chat-stream-with-files',
attachments: attachmentsFiles,
onProgress: (p0) {
print('file from chat-stream-with-files: progress: $p0');
onProgress: (progress) {
print('file from chat-stream-with-files: progress: $progress');
expect(progress, greaterThanOrEqualTo(0.0));
expect(progress, lessThanOrEqualTo(1.0));
},
));
expect(info, isNotNull);
Expand Down Expand Up @@ -307,8 +311,10 @@ void main() {
final info = await room.localParticipant?.sendFile(fileToSend,
options: SendFileOptions(
topic: 'file',
onProgress: (p0) {
print('progress: ${p0 * 100} %');
onProgress: (progress) {
print('progress: ${progress * 100} %');
expect(progress, greaterThanOrEqualTo(0.0));
expect(progress, lessThanOrEqualTo(1.0));
},
));
expect(info, isNotNull);
Expand Down
Loading