Fix publications' track property initialization#867
Merged
hiroshihorie merged 2 commits intomainfrom Sep 8, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an initialization issue where the track property was null immediately after construction of LocalTrackPublication and RemoteTrackPublication objects due to un-awaited async updateTrack() calls.
- Modified the base
TrackPublicationconstructor to accept and directly initialize thetrackparameter - Extracted track listener attachment logic into a reusable private method
- Updated both
LocalTrackPublicationandRemoteTrackPublicationto pass the track parameter to the parent constructor instead of callingupdateTrack()
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/src/publication/track_publication.dart | Added track parameter to constructor and extracted listener attachment logic |
| lib/src/publication/remote.dart | Updated constructor to pass track to parent instead of calling updateTrack() |
| lib/src/publication/local.dart | Updated constructor to pass track to parent instead of calling updateTrack() |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cloudwebrtc
approved these changes
Sep 8, 2025
DumbDev168
pushed a commit
to DumbDev168/client-sdk-flutter
that referenced
this pull request
Nov 4, 2025
This reverts commit 9e3f0ab.
|
hi @hiroshihorie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructors of
LocalTrackPublicationandRemoteTrackPublicationrelied on setting thetrackproperty during initialization. However, becauseupdateTrack()was an un-awaited async method, thetrackproperty was null immediately after construction, which caused confusion.