-
Notifications
You must be signed in to change notification settings - Fork 107
Implement RPC #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RPC #578
Conversation
# Conflicts: # livekit-android-sdk/src/main/java/io/livekit/android/room/participant/LocalParticipant.kt
🦋 Changeset detectedLatest commit: a2984b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a couple notes about the interface!
livekit-android-sdk/src/main/java/io/livekit/android/room/participant/LocalParticipant.kt
Outdated
Show resolved
Hide resolved
livekit-android-sdk/src/main/java/io/livekit/android/room/participant/LocalParticipant.kt
Outdated
Show resolved
Hide resolved
Pretty much identical to livekit/client-sdk-android#578 I included tests which mock the underlying data channel sending and receiving to test both sides in the same SDK app instance. --------- Co-authored-by: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>
* Update protocol * fix build errors * Implement RPC * tests * spotless * comment fixes # Conflicts: # protocol
No description provided.