Skip to content

Implement RPC #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Implement RPC #578

merged 7 commits into from
Jan 9, 2025

Conversation

davidliu
Copy link
Contributor

@davidliu davidliu commented Jan 8, 2025

No description provided.

# Conflicts:
#	livekit-android-sdk/src/main/java/io/livekit/android/room/participant/LocalParticipant.kt
Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: a2984b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
client-sdk-android Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bcherry bcherry self-requested a review January 8, 2025 07:08
Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple notes about the interface!

@davidliu davidliu requested a review from bcherry January 9, 2025 03:52
@davidliu davidliu merged commit 3319733 into main Jan 9, 2025
2 checks passed
@davidliu davidliu deleted the dl/rpc branch January 9, 2025 12:17
@davidliu davidliu mentioned this pull request Jan 9, 2025
bcherry added a commit to livekit/client-sdk-swift that referenced this pull request Jan 17, 2025
Pretty much identical to
livekit/client-sdk-android#578

I included tests which mock the underlying data channel sending and
receiving to test both sides in the same SDK app instance.

---------

Co-authored-by: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>
jeankruger pushed a commit to jeankruger/client-sdk-android that referenced this pull request May 1, 2025
* Update protocol

* fix build errors

* Implement RPC

* tests

* spotless

* comment fixes
# Conflicts:
#	protocol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants