add log_setup_fnc for cli.run_app

[longcw]

close #4339

for example

def log_setup(logger: logging.Logger, log_level: int | str):
    logger.setLevel(log_level)
    handler = logging.StreamHandler(sys.stdout)
    handler.setFormatter(logging.Formatter("%(asctime)s - %(levelname)s - %(message)s"))
    logger.addHandler(handler)


if __name__ == "__main__":
    cli.run_app(server, log_setup_fnc=log_setup)

[davidzhao]

ideally this isn't a CLI parameter, but something they could configure inside their agent? should there be a setup_logger_fnc on the cli itself? so they could make all sorts of customizations as needed.

also I'm not sure if the request is for colored logging.. but rather production systems prefer to parse text instead of JSON

[longcw]

ideally this isn't a CLI parameter, but something they could configure inside their agent?

users can remove the json handler in entrypoint but the original issue mentioned that

the JSON handler is only attached when cli.run_app is called. This means it cannot be removed except from within the entrypoint function, in which case there will be a period during which logs are emitted in JSON format.

maybe we can make it a callback of AgentServer or cli.run_app for user to customize rather than adding a CLI parameter.

[davidzhao]

the JSON handler is only attached when cli.run_app is called. This means it cannot be removed except from within the entrypoint function, in which case there will be a period during which logs are emitted in JSON format.

maybe we can make it a callback of AgentServer or cli.run_app for user to customize rather than adding a CLI parameter.

exactly, entrypoint is a bit too late, the framework logger has already been used by that point.. IMO giving users control is the right path, instead of automatically configuring colored logger

[theomonnom]

I'm wondering if we should just have a flag that disable any automatic logging configuration from the framework