fix silent generation on invalid AI functions #4374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidzhao
reviewed
Dec 23, 2025
| "speech_id": speech_handle.id, | ||
| }, | ||
| ) | ||
| _tool_completed( |
Member
There was a problem hiding this comment.
currently xai is calling these tools even though they are supposed to be executed on the server side, I'll raise with them.. but just to note that this will likely break the xai tools
Member
Author
There was a problem hiding this comment.
which tool did you test? XSearch or WebSearch?
Contributor
There was a problem hiding this comment.
for example, web + x search request:
14:32:53.218 WARNI… livekit.agents unknown AI function `web_search_with_snippets` {"function": "web_search_with_snippets", "speech_id": "speech_c7ce525a9080", "room": "mock_room"}
14:32:53.221 WARNI… livekit.agents unknown AI function `x_keyword_search` {"function": "x_keyword_search", "speech_id": "speech_c7ce525a9080", "room": "mock_room"}
14:32:53.223 WARNI… livekit.agents unknown AI function `x_semantic_search` {"function": "x_semantic_search", "speech_id": "speech_c7ce525a9080", "room": "mock_room"}
Contributor
There was a problem hiding this comment.
- x_semantic_search
- x_keyword_search
- x_user_search
- x_thread_fetch
- web_search_with_snippets
- browse_page
here is full list
Hormold
reviewed
Dec 23, 2025
| make_tool_output( | ||
| fnc_call=fnc_call, | ||
| output=None, | ||
| exception=RuntimeError(f"unknown AI function `{fnc_call.name}`"), |
Contributor
There was a problem hiding this comment.
Maybe we should expose the list of available functions back to the LLM to help with the next step (optionally)?
Member
Author
There was a problem hiding this comment.
It should already have it in context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #4352
avoid failing silently when the LLM hallucinates