AGT-2182: Add inference bargein and examples #4032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenghao-mou
force-pushed
the
chenghaomou/agt-2182-barge-in-detector-interface
branch
2 times, most recently
from
1fe7b1b to
783b91a
Compare
chenghao-mou
changed the title
chenghao-mou
force-pushed
the
chenghaomou/agt-2182-barge-in-detector-interface
branch
from
783b91a to
3d9d0af
Compare
chenghao-mou
force-pushed
the
chenghaomou/agt-2182-barge-in-detector-interface
branch
4 times, most recently
from
7b11b1d to
13a6fed
Compare
chenghao-mou
force-pushed
the
chenghaomou/agt-2182-barge-in-detector-interface
branch
2 times, most recently
from
6dfc839 to
45b5664
Compare
chenghao-mou
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
chenghao-mou
force-pushed
the
chenghaomou/agt-2182-barge-in-detector-interface
branch
3 times, most recently
from
120b12c to
bab9b18
Compare
chenghao-mou
force-pushed
the
chenghaomou/agt-2182-barge-in-detector-interface
branch
from
5868880 to
dbf4dbc
Compare
theomonnom
approved these changes
Dec 18, 2025
| self._log(DEV_LEVEL, message, args, **kwargs) | ||
|
|
||
|
|
||
| logging.setLoggerClass(Logger) |
| BargeinError, | ||
| BargeinEvent, | ||
| BargeinEventType, | ||
| BargeinStreamBase, |
Member
There was a problem hiding this comment.
Suggested change
| BargeinStreamBase, |
Should this one stays internal?
| self.update_vad(None) | ||
| self.update_bargein_detector(None) | ||
|
|
||
| def start_barge_in_monitoring(self) -> None: |
Member
There was a problem hiding this comment.
I think it's totally fine to name this:
on_agent_started_speaking
Member
Author
There was a problem hiding this comment.
Good point. Looking at the names we have today:
I think this set matches better:
wdyt?
|
|
||
| self._bargein_ch.send_nowait(inference.BargeinStreamBase._OverlapSpeechEndedSentinel()) | ||
|
|
||
| def end_barge_in_monitoring(self, ignore_until: float) -> None: |
|
|
||
| self._bargein_ch.send_nowait(inference.BargeinStreamBase._OverlapSpeechEndedSentinel()) | ||
|
|
||
| def end_barge_in_monitoring(self, ignore_until: float) -> None: |
Member
There was a problem hiding this comment.
Let's make it a kwargs & rename the parameter, otherwise it isn't obvious when reading the code from other places
Suggested change
| def end_barge_in_monitoring(self, ignore_until: float) -> None: | |
| def end_barge_in_monitoring(self, *, ignore_transcript_until: float) -> None: |
chenghao-mou
force-pushed
the
chenghaomou/agt-2182-barge-in-detector-interface
branch
from
2a2c610 to
817caa5
Compare
chenghao-mou
deleted the
chenghaomou/agt-2182-barge-in-detector-interface
branch
chenghao-mou
added a commit
that referenced
this pull request
Dec 19, 2025
chenghao-mou
added a commit
that referenced
this pull request
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed spec can be found in the notion page