support video input from screenshare #2127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
longcw
commented
Apr 25, 2025
•
longcw
commented
- always use the latest published video track (camera or screenshare), close the screenshare will switch back to camera if any
- close and reopen (mute or unmute) the camera when it reads from the screenshare it won’t switch to the camera until the screen share stopped
✅ Changeset File DetectedThe following changeset entries were found:
Change description: |
bcherry
reviewed
Apr 25, 2025
davidzhao
approved these changes
Apr 26, 2025
| @@ -50,7 +58,7 @@ def on_attached(self) -> None: | |||
| "input stream attached", | |||
| extra={ | |||
| "participant": self._participant_identity, | |||
| "source": rtc.TrackSource.Name(self._track_source), | |||
There was a problem hiding this comment.
I think it's fine to keep the singular source. for consistency when using Datadog or other search tools, it's far easier to search for source always, instead of trying to figure out to specify sources or source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.