Skip to content

add llm flush sentinel for llm_node #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

longcw
Copy link
Contributor

@longcw longcw commented Apr 17, 2025

No description provided.

@longcw longcw requested a review from a team April 17, 2025 02:37
Copy link
Contributor

github-actions bot commented Apr 17, 2025

✅ Changeset File Detected

The following changeset entries were found:

  • patch - livekit-agents

Change description:
add llm flush sentinel for llm_node (#2023)

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do this without modifying the entire chain? it seems this can be limited to the llm_node itself.. where once we detect it, close the next tts stream/transcription stream and then start another one.

that seems cleaner than having to propagate this down. user code in tts_node shouldn't have to care about it

@longcw
Copy link
Contributor Author

longcw commented Apr 18, 2025

can we do this without modifying the entire chain? it seems this can be limited to the llm_node itself.. where once we detect it, close the next tts stream/transcription stream and then start another one.

that seems cleaner than having to propagate this down. user code in tts_node shouldn't have to care about it

it's feasible to propagate to perform_tts_inference in agent activity, and handle the flush sentinel there by close and create tts_stream so the tts_node only see a text stream.

@longcw longcw requested review from davidzhao and a team April 18, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants