Skip to content

Conversation

@jayeshp19
Copy link
Contributor

@jayeshp19 jayeshp19 commented Feb 4, 2025

  • add latest models from google
  • updated testcase for array arguments

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: a6eac32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-plugins-google Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jayeshp19 jayeshp19 requested a review from a team February 5, 2025 16:53
@jayeshp19 jayeshp19 marked this pull request as ready for review February 5, 2025 16:54
@@ -382,7 +382,7 @@ def _on_input_speech_done(self, content: TranscriptionContent) -> None:
# TODO: implement sync mechanism to make sure the transcribed user speech is inside the chat_ctx and always before the generated agent speech

def _on_agent_speech_done(self, content: TranscriptionContent) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when interrupted, are we only transcribing until the moment of interruption?

Copy link
Contributor Author

@jayeshp19 jayeshp19 Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the current implementation transcribes the entire text (all the frames which are received before interruption). It's hard to determine the exact point of interruption since we receive frames faster than the actual playback.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. I think that's fine.. in the v1 branch, the synchronization/truncation logic will be downstream from the model.. model should just produce the entire thing.

@jayeshp19 jayeshp19 merged commit 5f977fa into main Feb 6, 2025
14 checks passed
@jayeshp19 jayeshp19 deleted the gemini-realtime-agent-audio branch February 6, 2025 19:40
jayesh-mivi pushed a commit to mivi-dev-org/custom-livekit-agents that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants