Skip to content

fix: Do not set fnc_ctx to None for anthropic at max depth #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jayeshp19 merged 10 commits into from
Feb 6, 2025
Merged

fix: Do not set fnc_ctx to None for anthropic at max depth #1441

jayeshp19 merged 10 commits into from
Feb 6, 2025

Conversation

@jayeshp19
Copy link
Contributor

@jayeshp19 jayeshp19 commented Feb 3, 2025

  • Added an additional field in LLM capabilities class to check if model providers support function call history within chat context without needing function definitions.

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1398dbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jayeshp19 jayeshp19 requested a review from a team February 3, 2025 08:51
theomonnom
theomonnom reviewed Feb 3, 2025
View reviewed changes
@jayeshp19 jayeshp19 marked this pull request as ready for review February 6, 2025 19:39
davidzhao
davidzhao reviewed Feb 6, 2025
View reviewed changes
davidzhao
davidzhao reviewed Feb 6, 2025
View reviewed changes
livekit-agents/livekit/agents/llm/llm.py Outdated
Generic[TEvent],
):
def __init__(self) -> None:
def __init__(self, *, capabilities: LLMCapabilities) -> None:
Copy link
Member

@davidzhao davidzhao Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should default this to None, and init if none

Copy link
Contributor Author

@jayeshp19 jayeshp19 Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we should correct this for TTS and STT as well.

davidzhao
davidzhao approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@jayeshp19 jayeshp19 merged commit 0865638 into main Feb 6, 2025
14 checks passed
@jayeshp19 jayeshp19 deleted the anthropic_fix_fnc_ctx branch February 6, 2025 20:04
This was referenced Feb 6, 2025
Merged
Open
Open
Closed
Open
jayesh-mivi pushed a commit to mivi-dev-org/custom-livekit-agents that referenced this pull request Jun 4, 2025
@jayeshp19
fix: Do not set fnc_ctx to None for anthropic at max depth (livekit#1441
df4b8d9 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theomonnom theomonnom theomonnom left review comments

@davidzhao davidzhao davidzhao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jayeshp19 @davidzhao @theomonnom