wip injectable stream #408
Conversation
|
| ]); | ||
| } | ||
|
|
||
| get readable() { |
There was a problem hiding this comment.
Do we also consider supporting "eject" (read single value from stream) operation? Basically making stream also have a queue-like API with put as inject and get as eject
There was a problem hiding this comment.
Sure if there's a concrete use case?
I'd be in favor of implementing additional features (generally) only once we know we have a defined use case for it.
| } | ||
| } | ||
|
|
||
| async close() { |
There was a problem hiding this comment.
@toubatbrian might be worth taking over this PR and working on the releasing the lock on the readable source once we close the stream.
Some tests would be good to.
| @@ -2,6 +2,7 @@ | |||
| "extends": "../tsconfig.json", | |||
|
|
|||
| "compilerOptions": { | |||
| "types": ["node"], | |||
There was a problem hiding this comment.
instead of defining it here, I think it would make sense to define it in the root package.json so that all packages (including plugins) get it by default
No description provided.