This repository was archived by the owner on Aug 31, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 71
Add support for new device sizes in new stack templates #2138
Open
livecodepanos
wants to merge
1
commit into
develop-9.6
Choose a base branch
from
update_ide_new_file_menu
base: develop-9.6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+205
−21
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1364,16 +1364,39 @@ private function revMenubarFileMenu pContext | |
put true into tCanSaveStack | ||
end if | ||
|
||
local sDeviceList | ||
put \ | ||
"Generic Android 6-inch Phone (412,775)" & return & \ | ||
"Generic Android 7-inch Phablet (600, 1024)" & return & \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. extra space here compared to others |
||
"Generic Android 10-inch Tablet Portrait (720,1280)" & return & \ | ||
"Generic Android 10-inch Tablet Landscape 1280,720)" & return & \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing left paren |
||
"iPhone SE (320x568)" & return & \ | ||
"iPhone 6s//7//8 (375x667)" & return & \ | ||
"iPhone 6s+//7+//8+ (414x736)" & return & \ | ||
"iPhone X//XS//11 Pro (375x812)" & return & \ | ||
"iPhone XR//11 (414x896)" & return & \ | ||
"iPhone XS Max//11 Pro Max (414x896)" & return & \ | ||
"iPad 9.7-inch//Tablet Portrait (768x1024)" & return & \ | ||
"iPad 9.7-inch//Tablet Landscape (1024x768)" & return & \ | ||
"iPad 10.2-inch//Tablet Portrait (810x1080)" & return & \ | ||
"iPad 10.2-inch//Tablet Landscape (1080x810)" & return & \ | ||
"iPad 10.5-inch//Tablet Portrait (834x1112)" & return & \ | ||
"iPad 10.5-inch//Tablet Landscape (1112x834)" & return & \ | ||
"iPad 11-inch//Tablet Portrait (834x1194)" & return & \ | ||
"iPad 11-inch//Tablet Landscape (1194x834)" & return & \ | ||
"iPad 12.9-inch//Tablet Portrait (1024x1366)" & return & \ | ||
"iPad 12.9-inch//Tablet Landscape (1366x1024)" \ | ||
into sDeviceList | ||
|
||
local tFile | ||
put "&New Stack" & return after tFile | ||
put tab & "Default Size" & return after tFile | ||
put tab & "-" & return after tFile | ||
put tab & "iPhone 4 (320x480)" & return after tFile | ||
put tab & "iPhone 5 (320x568)" & return after tFile | ||
put tab & "iPhone 6 (375x667)" & return after tFile | ||
put tab & "iPhone 6 Plus (414x736)" & return after tFile | ||
put tab & "iPad//Tablet Portrait (768x1024)" & return after tFile | ||
put tab & "iPad//Tablet Landscape (1024x768)" & return after tFile | ||
|
||
repeat for each line tDevice in sDeviceList | ||
put tab & tDevice & return after tFile | ||
end repeat | ||
|
||
put tab & "-" & return after tFile | ||
put tab & "Script only Stack" & return after tFile | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the iOS ones use
x
rather than,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really would be better as a configuration file somewhere