Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and test the compiler #93

Merged
merged 33 commits into from
May 29, 2022
Merged

Refactor and test the compiler #93

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
a4fe23a
add initial compiler test
matthewmueller May 19, 2022
4eeac85
test CI against a linked V8
matthewmueller May 20, 2022
a42820c
wip compiler refactor
matthewmueller May 20, 2022
a809cd4
starting to consolidate
matthewmueller May 22, 2022
1d17888
more consolidation
matthewmueller May 22, 2022
4167724
wip
matthewmueller May 23, 2022
cb1f483
consolidating
matthewmueller May 23, 2022
13772d5
working on new test runner
matthewmueller May 24, 2022
3e1dc52
finalize testing apis
matthewmueller May 25, 2022
31395f1
migrating tests
matthewmueller May 25, 2022
c735268
improve testcli http response handling and started refactoring contro…
matthewmueller May 25, 2022
a155e3f
refactor controller, view and public tests
matthewmueller May 25, 2022
eab452f
revert error formatting, will do it top-level instead. refactor remai…
matthewmueller May 26, 2022
333fa39
extract out file descriptor passing. work on remaining tests
matthewmueller May 26, 2022
1ee44d2
fix remaining failed tests
matthewmueller May 26, 2022
0fe3c08
update test script to install bud binary into /usr/local/go/bin:/usr/…
matthewmueller May 26, 2022
6f26ec6
use go to install bud
matthewmueller May 26, 2022
3d04db9
fix public test for CI
matthewmueller May 26, 2022
7571323
fix public tests
matthewmueller May 26, 2022
2f1436c
add hot client for testing the hot server. trying to reproduce view e…
matthewmueller May 27, 2022
10c17ec
add custom flag parsing support
matthewmueller May 27, 2022
3649a90
add dockerfile for development and fix failing ubuntu tests
matthewmueller May 28, 2022
3a6795d
update timeout
matthewmueller May 28, 2022
63bfe61
remove unused go modules
matthewmueller May 28, 2022
7c9ca94
delete unused files
matthewmueller May 28, 2022
9b51c92
replace matryer/is with internal/is.
matthewmueller May 28, 2022
9716d66
fix formatting
matthewmueller May 28, 2022
96ce936
fix hot reload and scaffolding new root controllers
matthewmueller May 28, 2022
c8300d7
debug panic
matthewmueller May 28, 2022
94870e8
fix test
matthewmueller May 28, 2022
7dc82cf
debug panic
matthewmueller May 28, 2022
d3f11a4
add error check and test for panic seen in CI
matthewmueller May 29, 2022
6430b17
Support Go 1.16+
matthewmueller May 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use go to install bud
  • Loading branch information
@matthewmueller
matthewmueller committed May 28, 2022
commit 6f26ec6425e5038fc9250c6a6eb65077463d0ae4
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
# Temporary fix to get the tests working until we pass the V8 client as a
# os.Pipe
- name: Install bud binary into $PATH
run: curl -sf https://raw.githubusercontent.com/livebud/bud/main/install.sh | sh
run: go install github.com/livebud/bud@latest

Copy link
Contributor Author

@matthewmueller matthewmueller May 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will go away soon, we'll change v8client to use os.Pipe and the same technique we're using with TCP listeners to pass the file descriptors through the binaries via ExtraFiles. This is mostly setup now, just needs to be refactored in.

- name: Install bud node_modules
run: npm ci
Expand Down