Interpolates messages with variables #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Mar 16, 2023
josevalim
reviewed
Mar 16, 2023
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
|
@jonatanklosko @josevalim I think I handled all of your suggestions. I learned a lot in the process; thanks! Can you give it one last check, please? |
jonatanklosko
approved these changes
Mar 16, 2023
josevalim
reviewed
Mar 17, 2023
| ] | ||
| } | ||
|
|
||
| args ++ [interpolation_node] |
There was a problem hiding this comment.
You want to avoid appending to the end of the list, because it is expensive. The idea is that you always prepend and at the end you call Enum.reverse. This will also make operations such as append_string faster and easier, because you only need to access the head of the list. :)
|
@josevalim applied your last feedback regarding avoiding appending to the end of a List. I think we're good to now. Want to take a last look? |
josevalim
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the feature of interpolated messages.
The interpolation syntax is the same one from KinoDB. One can write a slack interpolated message like this