Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow any data structure that implements Table.Reader #75

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Allow any data structure that implements Table.Reader #75

merged 2 commits into from
Apr 30, 2023

Conversation

cristineguadelupe
Copy link
Contributor

No description provided.

@josevalim
Copy link
Contributor

@cristineguadelupe do we also change the interface so the first element in the "pipeline" is Explorer.DataFrame.new(variable) instead of just variable?

josevalim
josevalim approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and ship it!

@cristineguadelupe
Copy link
Contributor Author

@cristineguadelupe do we also change the interface so the first element in the "pipeline" is Explorer.DataFrame.new(variable) instead of just variable?

Done! And it respects the alias

@cristineguadelupe cristineguadelupe merged commit 75f895e into livebook-dev:main Apr 30, 2023
@cristineguadelupe cristineguadelupe deleted the cg-data-table-reader branch April 30, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristineguadelupe @josevalim