Fix SQL cell to keep the selected connection when not in binding #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
commented
Aug 15, 2024
Comment on lines
+82
to
+83
| # TODO: Use Code.env_for_eval on Elixir v1.14+ | ||
| env = :elixir.env_for_eval([]) |
There was a problem hiding this comment.
Kino requires Elixir v1.14, so we can bump it here too. I will push directly to main after the PR.
josevalim
approved these changes
Aug 15, 2024
|
We can ship a new release already, right? We don't have to wait? |
|
Yes, will do! |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario:
Let's say we restart the runtime and evaluate the first connection cell. Currently, the SQL cell would pick up
conn1and even starting the second connection wouldn't roll that back.This is a regression from #2. The corresponding change was made to update the selected database type, in case the user changes the connection cell to use different database and assigns into the same variable name.
I added tests for both #2 and the regression :)