Add support for AWS Athena #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to specify the S3 location? Or does it have a reasonable default? |
|
The code looks good to me! :) |
Sadly yes and their API docs doesn't mention that's required, but if we try to not send they return a status 400 with this error:
|
aleDsz
force-pushed
the
feature/support-athena
branch
from
0bcceab
to
09acf0d
Compare
aleDsz
force-pushed
the
feature/support-athena
branch
from
09acf0d
to
0cfd8b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KinoDB.-.AWS.Athena.mp4