Invitation Repository Query Test 구현 및 QR 도메인 로직 리팩토링 완료#34
Merged
cxxxtxxyxx merged 3 commits intolivable-final:developfrom Sep 19, 2023
Merged
Conversation
Contributor
cxxxtxxyxx
commented
Sep 18, 2023
cxxxtxxyxx
commented
- Invitation Repository Query Test 구현 및 QR 도메인 로직 리팩토링 #32
- 쿼리 한번에 해결하도록 JPQL 조인 사용함
- 해당 로직 수정하고, 테스트 또한 수정
khsrla9806
reviewed
Sep 19, 2023
| import static org.junit.jupiter.api.Assertions.assertAll; | ||
|
|
||
| @DataJpaTest | ||
| @Import(QueryDslConfig.class) |
Contributor
There was a problem hiding this comment.
이 부분 다른 곳에서도 계속 사용될거 생각하면 이번 Merge 후에 @DataJpaTest랑 @Import(QueryDslConfig.class) 기능하는 @DataJpaTestWithQueryDsl 이런 커스텀 어노테이션 한번 만들어 볼까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.