Skip to content

Commit

Permalink
Export all public functions of sc-service (paritytech#4457)
Browse files Browse the repository at this point in the history
paritytech#3166 made private
functions used in `spawn_tasks()` public but forgot to add them in
exported functions of the crate.

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
  • Loading branch information
3 people authored and liuchengxu committed Jun 19, 2024
1 parent 2ee8e13 commit 8ec33f6
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 4 deletions.
15 changes: 15 additions & 0 deletions prdoc/pr_4457.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: "sc-service: export all public functions"

doc:
- audience: Node Dev
description: |
A PR #3166 converted private functions used in `spawn_tasks()` to public to make it possible to have custom
implementation of the `spawn_tasks()`. However, not all functions were included in the list of exports from
`sc-service` crate.

crates:
- name: sc-service
bump: minor
9 changes: 5 additions & 4 deletions substrate/client/service/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,11 @@ use sp_runtime::traits::{Block as BlockT, Header as HeaderT};

pub use self::{
builder::{
build_network, new_client, new_db_backend, new_full_client, new_full_parts,
new_full_parts_record_import, new_full_parts_with_genesis_builder, new_wasm_executor,
spawn_tasks, BuildNetworkParams, KeystoreContainer, NetworkStarter, SpawnTasksParams,
TFullBackend, TFullCallExecutor, TFullClient,
build_network, gen_rpc_module, init_telemetry, new_client, new_db_backend, new_full_client,
new_full_parts, new_full_parts_record_import, new_full_parts_with_genesis_builder,
new_wasm_executor, propagate_transaction_notifications, spawn_tasks, BuildNetworkParams,
KeystoreContainer, NetworkStarter, SpawnTasksParams, TFullBackend, TFullCallExecutor,
TFullClient,
},
client::{ClientConfig, LocalCallExecutor},
error::Error,
Expand Down

0 comments on commit 8ec33f6

Please sign in to comment.