Skip to content

Fix allocation-eviction issue when erase state is multiple of block_cycles+1 #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Fix allocation-eviction issue when erase state is multiple of block_cycles+1 #490

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d04c139
Fixed allocation-eviction issue when erase state is multiple of block…
geky Nov 22, 2020
b8dcf10
Changed lfs_dir_alloc to maximize block cycles for new metadata pairs
geky Nov 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lfs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1375,8 +1375,12 @@ static int lfs_dir_alloc(lfs_t *lfs, lfs_mdir_t *dir) {
return err;
}

// make sure we don't immediately evict
dir->rev += dir->rev & 1;
// to make sure we don't immediately evict, align the new revision count
// to our block_cycles modulus, see lfs_dir_compact for why our modulus
// is tweaked this way
if (lfs->cfg->block_cycles > 0) {
dir->rev = lfs_alignup(dir->rev, ((lfs->cfg->block_cycles+1)|1));
}

// set defaults
dir->off = sizeof(dir->rev);
Expand Down