fix: avoid assuming struct packing #1084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfs_gstate_t was assumed to be a packed array of uint32_t, but this is not always guaranteed. Access the fields directly instead of attempting to loop over an array of uint32_t Fixes clang tidy warnings about use of uninitialized memory accessed.
Tests passed ✓, Code: 17112 B (+0.0%), Stack: 1448 B (+0.0%), Structs: 812 B (+0.0%)
|
lfs.c
Outdated
Comment on lines
413
to
422
| if (a->tag != 0) { | ||
| return false; | ||
| } | ||
| if (a->pair[0] != 0) { | ||
| return false; | ||
| } | ||
| if (a->pair[1] != 0) { | ||
| return false; | ||
| } | ||
| return true; |
There was a problem hiding this comment.
Nit: this could potentially be condensed (if not simplified) to:
return ((a->tag == 0) && (a->pair[0] == 0) && (a->pair[1] == 0));
|
Hi @elupus, thanks for this. Looks good to me. This wouldn't have been a blocker, but it's interesting to note this has zero impact on code size. I guess these loops were already unrolled given how small they are. |
geky
approved these changes
Mar 18, 2025
Tests passed ✓, Code: 17108 B (+0.0%), Stack: 1448 B (+0.0%), Structs: 812 B (+0.0%)
|
|
Thanx! |
|
It's not quite in master yet, but will be shortly if this CI job succeeds. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lfs_gstate_t was assumed to be a packed array of uint32_t, but this is not always guaranteed. Access the fields directly instead of attempting to loop over an array of uint32_t
Fixes clang tidy warnings about use of uninitialized memory accessed.