feat(workflows): Add get workflowruns command
#76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrayagS
requested review from
Jonsy13,
Saranya-jena and
SarthakJain26
as code owners
Signed-off-by: PrayagS <prayagsavsani@gmail.com>
PrayagS
force-pushed
the
feat-get-workflowruns-cmd
branch
from
0d88396 to
110cff2
Compare
SarthakJain26
requested changes
Jun 9, 2022
pkg/apis/workflow.go
Outdated
|
|
||
| return workflowRunsList, nil | ||
| } else { | ||
| return WorkflowRunsListData{}, err |
Collaborator
There was a problem hiding this comment.
This block will be executed if resp.StatusCode != http.StatusOK. In that case else block will return WorkflowRunsListData{}, nil since error will always be handled on line 269. So instead we can return custom error message.
Saranya-jena
approved these changes
Jun 13, 2022
imrajdas
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: PrayagS prayagsavsani@gmail.com